Skip to content

refactor: refactor clean_projects to reduce redundancy in outputs - #807

Open
tgilon wants to merge 5 commits into
feat/720-custom-projectsfrom
refactor/804-clean-projects
Open

refactor: refactor clean_projects to reduce redundancy in outputs#807
tgilon wants to merge 5 commits into
feat/720-custom-projectsfrom
refactor/804-clean-projects

Conversation

@tgilon

@tgilon tgilon commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #804.

Changes proposed in this Pull Request

Tasks

Workflow

Open issues

Notes

Generative AI was used to assist with prose review. All content has been reviewed, verified, and is the responsibility of the author.

Checklist

Required:

  • Security scans show no high-severity bugs, critical vulnerabilities, or exposed secrets.
  • Changes are tested locally and behave as expected.
  • Code and workflow changes are documented.
  • A release note entry is added to doc/release_notes.md.
  • The description is human-written and any AI-generated content is marked.

If applicable:

  • Changes in configuration options are reflected in scripts/lib/validation.
  • Changes in configuration options are added to config/test/*.yaml.
  • Multiple climate years test passes locally (pixi run -e open-tyndp tyndp-cyears-test).
  • For new data sources or versions, these instructions have been followed.
  • Open-TYNDP SPDX license header is added to all touched files.
  • Module docstrings are added to new Python scripts.
  • New rules are documented in the appropriate doc/*.md files.
  • Major features are documented in doc/index.md.

@tgilon tgilon added this to the Release v0.8 milestone Jul 24, 2026
@tgilon tgilon self-assigned this Jul 24, 2026
@tgilon tgilon added the CBA Cost Benefit Analysis label Jul 24, 2026
@tgilon
tgilon requested a review from daniel-rdt July 24, 2026 10:54
@tgilon
tgilon marked this pull request as ready for review July 24, 2026 10:55
@daniel-rdt daniel-rdt linked an issue Jul 28, 2026 that may be closed by this pull request
Refactor clean_projects to reduce redundancy in outputs #804
Open
1 task
daniel-rdt
daniel-rdt approved these changes Jul 31, 2026
View reviewed changes

@daniel-rdt daniel-rdt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tgilon. This is clean and definitely makes sense to me to only save the relevant information based on the unique project_id in the method table output.

Some small suggestions and you accidentally linked the issue instead of the PR in the release note. Otherwise, this is good for me and I will already approve 👍

Comment thread scripts/cba/clean_projects.py
Comment thread scripts/cba/clean_projects.py Outdated
Comment thread doc/release_notes.md Outdated
Comment thread scripts/cba/prepare_project.py Outdated
@tgilon tgilon mentioned this pull request Jul 31, 2026
Open
29 tasks
@tgilon tgilon removed this from the Release v0.8 milestone Jul 31, 2026
@tgilon @daniel-rdt
Apply suggestions from code review
6a1a970 
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
@tgilon

tgilon commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Ready to be merged after #802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-rdt daniel-rdt daniel-rdt approved these changes

Assignees

@tgilon tgilon

Labels

CBA Cost Benefit Analysis

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor clean_projects to reduce redundancy in outputs

2 participants

@tgilon @daniel-rdt